From 06d56bf4ac2a43283d7446e7cf05097d3b018bbb Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 8 May 2016 14:57:12 -0400 Subject: [PATCH] update shellcheck ignores --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 93a7332..2b6ee66 100644 --- a/Makefile +++ b/Makefile @@ -24,11 +24,10 @@ ci-dependencies: shellcheck bats lint: # these are disabled due to their expansive existence in the codebase. we should clean it up though - # SC2046: Quote this to prevent word splitting. - https://github.com/koalaman/shellcheck/wiki/SC2046 - # SC2068: Double quote array expansions, otherwise they're like $* and break on spaces. - https://github.com/koalaman/shellcheck/wiki/SC2068 - # SC2086: Double quote to prevent globbing and word splitting - https://github.com/koalaman/shellcheck/wiki/SC2086 + # SC1090: Can't follow non-constant source. Use a directive to specify location. + # SC2155: Declare and assign separately to avoid masking return values. @echo linting... - @$(QUIET) find ./ -maxdepth 1 -not -path '*/\.*' | xargs file | egrep "shell|bash" | awk '{ print $$1 }' | sed 's/://g' | xargs shellcheck -e SC2046,SC2068,SC2086 + @$(QUIET) find ./ -maxdepth 1 -not -path '*/\.*' | xargs file | egrep "shell|bash" | awk '{ print $$1 }' | sed 's/://g' | xargs shellcheck -e SC1090,SC2155 unit-tests: @echo running unit tests...