From 29caa1372505af27f5c2d09f68aef43a4679165f Mon Sep 17 00:00:00 2001
From: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Date: Mon, 13 Sep 2021 03:21:23 -0400
Subject: [PATCH] docs: document the possibility of zombie processes on ssh
 disconnect for :connect and :enter commands

Apparently terminating the ssh connection that runs 'docker exec' may result in a process leak as the signal isn't propagated properly (moby/moby#9098). Since we cannot fix this, we should document it so that users do not stumble upon the issue unawares.

Closes dokku/dokku-postgres#212
---
 README.md           | 4 ++++
 subcommands/connect | 1 +
 subcommands/enter   | 1 +
 3 files changed, 6 insertions(+)

diff --git a/README.md b/README.md
index a464b0e..3b5a90a 100644
--- a/README.md
+++ b/README.md
@@ -257,6 +257,8 @@ dokku mongo:connect <service>
 
 Connect to the service via the mongo connection tool:
 
+> NOTE: disconnecting from ssh while running this command may leave zombie processes due to moby/moby#9098
+
 ```shell
 dokku mongo:connect lollipop
 ```
@@ -270,6 +272,8 @@ dokku mongo:enter <service>
 
 A bash prompt can be opened against a running service. Filesystem changes will not be saved to disk.
 
+> NOTE: disconnecting from ssh while running this command may leave zombie processes due to moby/moby#9098
+
 ```shell
 dokku mongo:enter lollipop
 ```
diff --git a/subcommands/connect b/subcommands/connect
index 8f2a0d7..37d05a8 100755
--- a/subcommands/connect
+++ b/subcommands/connect
@@ -7,6 +7,7 @@ source "$(dirname "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)")/functions"
 
 service-connect-cmd() {
   #E connect to the service via the $PLUGIN_COMMAND_PREFIX connection tool
+  #E > NOTE: disconnecting from ssh while running this command may leave zombie processes due to moby/moby#9098
   #E dokku $PLUGIN_COMMAND_PREFIX:connect lollipop
   #A service, service to run command against
   declare desc="connect to the service via the $PLUGIN_COMMAND_PREFIX connection tool"
diff --git a/subcommands/enter b/subcommands/enter
index bfe9f50..4af6cfc 100755
--- a/subcommands/enter
+++ b/subcommands/enter
@@ -8,6 +8,7 @@ source "$(dirname "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)")/functions"
 service-enter-cmd() {
   #E a bash prompt can be opened against a running service.
   #E filesystem changes will not be saved to disk.
+  #E > NOTE: disconnecting from ssh while running this command may leave zombie processes due to moby/moby#9098
   #E dokku $PLUGIN_COMMAND_PREFIX:enter lollipop
   #E you may also run a command directly against the service.
   #E filesystem changes will not be saved to disk.