From 2be3a4d5028dbe02d774f0faf6855744c88d987b Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Wed, 27 Mar 2019 12:18:18 -0400 Subject: [PATCH 1/2] fix: correct issue where aliases were being generated incorrectly --- common-functions | 5 +++-- tests/service_link.bats | 11 ++++++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/common-functions b/common-functions index 1bd8ee1..674db66 100755 --- a/common-functions +++ b/common-functions @@ -113,9 +113,10 @@ service_alternative_alias() { for COLOR in "${COLORS[@]}"; do ALIAS="${PLUGIN_ALT_ALIAS}_${COLOR}" local IN_USE=$(echo "$EXISTING_CONFIG" | grep "${ALIAS}_URL") - if [[ -n $IN_USE ]]; then - unset ALIAS + if [[ -z "$IN_USE" ]]; then + break fi + unset ALIAS done echo "$ALIAS" } diff --git a/tests/service_link.bats b/tests/service_link.bats index 706952b..2c1c396 100755 --- a/tests/service_link.bats +++ b/tests/service_link.bats @@ -3,14 +3,17 @@ load test_helper setup() { dokku "$PLUGIN_COMMAND_PREFIX:create" l + dokku "$PLUGIN_COMMAND_PREFIX:create" m dokku apps:create my_app } teardown() { + dokku --force "$PLUGIN_COMMAND_PREFIX:destroy" m dokku --force "$PLUGIN_COMMAND_PREFIX:destroy" l dokku --force apps:destroy my_app } + @test "($PLUGIN_COMMAND_PREFIX:link) error when there are no arguments" { run dokku "$PLUGIN_COMMAND_PREFIX:link" echo "output: $output" @@ -69,8 +72,14 @@ teardown() { dokku config:set my_app MONGO_URL=mongodb://user:pass@host:27017/db dokku "$PLUGIN_COMMAND_PREFIX:link" l my_app run dokku config my_app - assert_contains "${lines[*]}" "DOKKU_MONGO_" + assert_contains "${lines[*]}" "DOKKU_MONGODB_AQUA_URL" assert_success + + dokku "$PLUGIN_COMMAND_PREFIX:link" m my_app + run dokku config my_app + assert_contains "${lines[*]}" "DOKKU_MONGODB_BLACK_URL" + assert_success + dokku "$PLUGIN_COMMAND_PREFIX:unlink" m my_app dokku "$PLUGIN_COMMAND_PREFIX:unlink" l my_app } From 031c45ebb797737d31399076b2ad2768e4915a17 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Wed, 27 Mar 2019 22:17:42 -0400 Subject: [PATCH 2/2] fix: correct env var --- tests/service_link.bats | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/service_link.bats b/tests/service_link.bats index 2c1c396..08e52ca 100755 --- a/tests/service_link.bats +++ b/tests/service_link.bats @@ -72,12 +72,12 @@ teardown() { dokku config:set my_app MONGO_URL=mongodb://user:pass@host:27017/db dokku "$PLUGIN_COMMAND_PREFIX:link" l my_app run dokku config my_app - assert_contains "${lines[*]}" "DOKKU_MONGODB_AQUA_URL" + assert_contains "${lines[*]}" "DOKKU_MONGO_AQUA_URL" assert_success dokku "$PLUGIN_COMMAND_PREFIX:link" m my_app run dokku config my_app - assert_contains "${lines[*]}" "DOKKU_MONGODB_BLACK_URL" + assert_contains "${lines[*]}" "DOKKU_MONGO_BLACK_URL" assert_success dokku "$PLUGIN_COMMAND_PREFIX:unlink" m my_app dokku "$PLUGIN_COMMAND_PREFIX:unlink" l my_app