Commit Graph

5 Commits

Author SHA1 Message Date
Jose Diaz-Gonzalez
ade8b44569 feat: re-allow dashes in names
This PR allows dashes in service names, while still sanitizing them before they are used as database names. If the datastore is pre-existing, the datatabase name is assumed to be the same as the service name, and returned appropriately.
2019-05-30 17:03:48 -04:00
Jose Diaz-Gonzalez
9b8fabc2e7 feat: Real docker-based testing
This pull request switches testing to use an actual docker daemon, vs mocking everything out.

It may also catch actual breaking issues in our tests, which is great!
2019-03-18 14:44:27 -04:00
Jose Diaz-Gonzalez
bc6a5422d6 fix: correct the validation message 2019-03-09 16:39:34 -05:00
Jose Diaz-Gonzalez
cd5b3a14b8 fix: Strictly validate service names
We previously allowed a wide range of service names. As the service name is sometimes used to name databases, the name was actually more restricted than any character, resulting in services that wouldn't start. Going forward, only alphanumeric and underscore characters are allowed.

This only impacts service creation. Any services with invalid names should be migrated to a new service, with the data exported and imported as normal.

Closes dokku/dokku-redis#99
Closes dokku/dokku-mysql#47
Closes dokku/dokku-mongo#86
Closes dokku/dokku-redis#81
2019-03-09 15:54:21 -05:00
Loïc Guitaut
12557fbaa1 Add tests for every implemented command 2015-09-10 16:21:35 +02:00