From ed649843c56212b3dd0f18c8d3b0e62f3869001d Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 12 Sep 2021 07:19:26 -0400 Subject: [PATCH] fix: correct lint error and ensure arg gets properly expanded --- functions | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/functions b/functions index eb76466..40cce6c 100755 --- a/functions +++ b/functions @@ -85,8 +85,9 @@ service_create_container() { local PASSWORD="$(service_password "$SERVICE")" local DATABASE_NAME="$(get_database_name "$SERVICE")" local MEMORY_LIMIT="" - if [[ ! -z $SERVICE_MEMORY ]]; then - MEMORY_LIMIT="-m ${SERVICE_MEMORY}" + + if [[ ! -z "$SERVICE_MEMORY" ]]; then + MEMORY_LIMIT="--memory=${SERVICE_MEMORY}" fi ID=$(docker run --name "$SERVICE_NAME" "$MEMORY_LIMIT" -v "$SERVICE_HOST_ROOT/data:/var/lib/mysql" -v "$SERVICE_HOST_ROOT/$PLUGIN_CONFIG_SUFFIX:/etc/mysql/conf.d" -e "MYSQL_ROOT_PASSWORD=$ROOTPASSWORD" -e MYSQL_USER=mysql -e "MYSQL_PASSWORD=$PASSWORD" -e "MYSQL_DATABASE=$DATABASE_NAME" --env-file="$SERVICE_ROOT/ENV" -d --restart always --label dokku=service --label dokku.service=mysql "$PLUGIN_IMAGE:$PLUGIN_IMAGE_VERSION")