From 62e132ed2d0248b303b19e0afbd203226b6bc7cb Mon Sep 17 00:00:00 2001
From: Enzo Macari <emacari@claritywave.com>
Date: Wed, 17 Jul 2024 23:26:13 -0400
Subject: [PATCH] Fix url checker. Old code fail if any variables contain the
 alias so FOO_REDIS_URL would match and believe its already defined.

---
 common-functions | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/common-functions b/common-functions
index c0ba352..d85409b 100755
--- a/common-functions
+++ b/common-functions
@@ -600,7 +600,7 @@ service_link() {
   local SERVICE_NAME="$(get_service_name "$SERVICE")"
   local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE"
   local EXISTING_CONFIG=$(config_all "$APP")
-  local LINK=$(echo "$EXISTING_CONFIG" | grep "$SERVICE_URL" | cut -d: -f1) || true
+  local LINK=$(echo "$EXISTING_CONFIG" | grep "^$SERVICE_URL\$" | cut -d: -f1) || true
   local SERVICE_DNS_HOSTNAME=$(service_dns_hostname "$SERVICE")
   local LINKS_FILE="$SERVICE_ROOT/LINKS"
   local ALIAS="$PLUGIN_DEFAULT_ALIAS"
@@ -608,17 +608,17 @@ service_link() {
 
   if [[ -n "$SERVICE_ALIAS" ]]; then
     ALIAS="$SERVICE_ALIAS"
-    ALIAS_IN_USE=$(echo "$EXISTING_CONFIG" | grep "${ALIAS}_URL") || true
+    ALIAS_IN_USE=$(config_keys "$APP" | tr ' ' '\n' | grep "^${ALIAS}_URL\$") || true
     [[ -n "$ALIAS_IN_USE" ]] && dokku_log_fail "Specified alias $ALIAS already in use"
   else
-    DEFAULT_ALIAS=$(echo "$EXISTING_CONFIG" | grep "${PLUGIN_DEFAULT_ALIAS}_URL") || true
+    DEFAULT_ALIAS=$(config_keys "$APP" | tr ' ' '\n' | grep "^${ALIAS}_URL\$") || true
     if [[ -n "$DEFAULT_ALIAS" ]]; then
       ALIAS=$(service_alternative_alias "$EXISTING_CONFIG")
     fi
     [[ -z "$ALIAS" ]] && dokku_log_fail "Unable to use default or generated URL alias"
   fi
 
-  [[ -n $LINK ]] && dokku_log_fail "Already linked as $LINK"
+  [[ -n $LINK ]] && [[ -n $SERVICE_ALIAS ]] && dokku_log_fail "Already linked as $LINK"
   plugn trigger service-action pre-link "$PLUGIN_COMMAND_PREFIX" "$SERVICE" "$APP"
   add_to_links_file "$SERVICE" "$APP"