diff --git a/commands b/commands index 670e732..f9bf4bb 100755 --- a/commands +++ b/commands @@ -46,7 +46,7 @@ case "$1" in [[ -z $2 ]] && dokku_log_fail "Please specify a name for the service" verify_service_name "$2" SERVICE="$2"; SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE"; LINKS_FILE="$SERVICE_ROOT/LINKS" - SERVICE_NAME=$(get_service_name "$SERVICE") + SERVICE_NAME="$(get_service_name "$SERVICE")" [[ -s "$LINKS_FILE" ]] && dokku_log_fail "Cannot delete linked service" @@ -102,7 +102,7 @@ case "$1" in [[ -z $2 ]] && dokku_log_fail "Please specify a name for the service" verify_service_name "$2" SERVICE="$2"; SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - SERVICE_NAME=$(get_service_name "$SERVICE") + SERVICE_NAME="$(get_service_name "$SERVICE")" [[ -n $SSH_TTY ]] && stty -opost docker exec "$SERVICE_NAME" bash -c "echo SAVE | redis-cli" > /dev/null 2>&1 @@ -116,7 +116,7 @@ case "$1" in [[ -z $2 ]] && dokku_log_fail "Please specify a name for the service" verify_service_name "$2" SERVICE="$2"; SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - SERVICE_NAME=$(get_service_name "$SERVICE") + SERVICE_NAME="$(get_service_name "$SERVICE")" if [[ -t 0 ]]; then dokku_log_fail "No data provided on stdin." @@ -156,7 +156,7 @@ case "$1" in [[ -z $2 ]] && dokku_log_fail "Please specify a name for the service" verify_service_name "$2" SERVICE="$2"; SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - SERVICE_NAME=$(get_service_name "$SERVICE") + SERVICE_NAME="$(get_service_name "$SERVICE")" has_tty && SERVICE_TTY_OPTS="-t" docker exec -i $SERVICE_TTY_OPTS "$SERVICE_NAME" redis-cli diff --git a/functions b/functions index e83cdce..11becb8 100755 --- a/functions +++ b/functions @@ -33,7 +33,7 @@ verify_service_name() { service_alias() { local SERVICE="$1" - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" echo "$SERVICE_NAME" | tr ._ - } @@ -73,7 +73,7 @@ service_link() { local SERVICE="$1" update_plugin_scheme_for_app "$APP" local SERVICE_URL=$(service_url "$SERVICE") - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" local EXISTING_CONFIG=$(config_all "$APP") local LINK=$(echo "$EXISTING_CONFIG" | grep "$SERVICE_URL" | cut -d: -f1) || true @@ -186,7 +186,7 @@ service_port_unexpose() { service_port_unpause() { local SERVICE="$1" local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" local EXPOSED_NAME="${SERVICE_NAME}.ambassador" local PORT_FILE="$SERVICE_ROOT/PORT" local LOG_FAIL="$2" @@ -225,7 +225,7 @@ service_start() { local SERVICE="$1" local QUIET="$2" local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" local ID=$(docker ps -f status=running | grep -e "$SERVICE_NAME$" | awk '{print $1}') || true if [[ -n $ID ]]; then [[ -z $QUIET ]] && dokku_log_warn "Service is already started" @@ -250,7 +250,7 @@ service_start() { service_create_container() { local SERVICE="$1" local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE" - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" ID=$(docker run --name "$SERVICE_NAME" -v "$SERVICE_ROOT/data:/data" -v "$SERVICE_ROOT/config:/usr/local/etc/redis" --env-file="$SERVICE_ROOT/ENV" -d --restart always --label dokku=service --label dokku.service=redis "$PLUGIN_IMAGE:$PLUGIN_IMAGE_VERSION" redis-server /usr/local/etc/redis/redis.conf) echo "$ID" > "$SERVICE_ROOT/ID" @@ -265,7 +265,7 @@ service_create_container() { service_stop() { local SERVICE="$1" local SERVICE_ROOT="$PLUGIN_DATA_ROOT/$SERVICE"; - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" local ID=$(docker ps -f status=running | grep -e "$SERVICE_NAME$" | awk '{print $1}') || true [[ -z $ID ]] && dokku_log_warn "Service is already stopped" && return 0 @@ -284,7 +284,7 @@ service_unlink() { local SERVICE="$1" update_plugin_scheme_for_app "$APP" local SERVICE_URL=$(service_url "$SERVICE") - local SERVICE_NAME=$(get_service_name "$SERVICE") + local SERVICE_NAME="$(get_service_name "$SERVICE")" local EXISTING_CONFIG=$(config_all "$APP") local SERVICE_ALIAS=$(service_alias "$SERVICE") local LINK=($(echo "$EXISTING_CONFIG" | grep "$SERVICE_URL" | cut -d: -f1)) || true