From a9021655470943f979117a9048fc227de846f91e Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sat, 25 Feb 2023 01:50:30 -0500 Subject: [PATCH] fix: update link docs to remove erroneous copy-paste --- README.md | 10 ++-------- subcommands/link | 8 ++------ 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index 61a0460..bc87acc 100644 --- a/README.md +++ b/README.md @@ -224,7 +224,7 @@ DOKKU_REDIS_LOLLIPOP_PORT_6379_TCP_ADDR=172.17.0.1 The following will be set on the linked application by default: ``` -REDIS_URL=redis://lollipop:SOME_PASSWORD@dokku-redis-lollipop:6379/lollipop +REDIS_URL=redis://:SOME_PASSWORD@dokku-redis-lollipop:6379 ``` The host exposed here only works internally in docker containers. If you want your container to be reachable from outside, you should use the `expose` subcommand. Another service can be linked to your app: @@ -243,13 +243,7 @@ dokku redis:link lollipop playground This will cause `REDIS_URL` to be set as: ``` -redis2://lollipop:SOME_PASSWORD@dokku-redis-lollipop:6379/lollipop -``` - -If you specify `REDIS_DATABASE_SCHEME` to equal `http`, we`ll also automatically adjust `REDIS_URL` to match the http interface: - -``` -http://lollipop:SOME_PASSWORD@dokku-redis-lollipop:${PLUGIN_DATASTORE_PORTS[1]} +redis2://:SOME_PASSWORD@dokku-redis-lollipop:6379 ``` ### unlink the redis service from the app diff --git a/subcommands/link b/subcommands/link index f59f82a..661ce49 100755 --- a/subcommands/link +++ b/subcommands/link @@ -23,7 +23,7 @@ service-link-cmd() { #E #E the following will be set on the linked application by default: #E - #E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop + #E ${PLUGIN_DEFAULT_ALIAS}_URL=${PLUGIN_SCHEME}://:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]} #E #E the host exposed here only works internally in docker containers. #E if you want your container to be reachable from outside, you should @@ -37,11 +37,7 @@ service-link-cmd() { #E dokku $PLUGIN_COMMAND_PREFIX:link lollipop playground #E this will cause ${PLUGIN_DEFAULT_ALIAS}_URL to be set as: #E - #E ${PLUGIN_SCHEME}2://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]}/lollipop - #E - #E If you specify ${PLUGIN_VARIABLE}_DATABASE_SCHEME to equal `http`, we'll also automatically adjust ${PLUGIN_DEFAULT_ALIAS}_URL to match the http interface: - #E - #E http://lollipop:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[1]} + #E ${PLUGIN_SCHEME}2://:SOME_PASSWORD@dokku-${PLUGIN_COMMAND_PREFIX}-lollipop:${PLUGIN_DATASTORE_PORTS[0]} #A service, service to run command against #A app, app to run command against #F -a|--alias "BLUE_DATABASE", an alternative alias to use for linking to an app via environment variable