From b2066c32c0bb7888cc5def3d85abaf472c907f9f Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sat, 26 Aug 2017 05:49:56 -0400 Subject: [PATCH] fix: warn that a specified password may not be as secure as the autogenerated one --- functions | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/functions b/functions index e095d00..0802e93 100755 --- a/functions +++ b/functions @@ -26,7 +26,10 @@ service_create() { mkdir -p "$SERVICE_ROOT/config" || dokku_log_fail "Unable to create service config directory" curl -sSL "https://raw.githubusercontent.com/antirez/redis/${PLUGIN_IMAGE_VERSION:0:3}/redis.conf" > "$SERVICE_ROOT/config/redis.conf" || dokku_log_fail "Unable to download the default redis.conf to the config directory" PASSWORD=$(openssl rand -hex 32) - [[ -n "$SERVICE_PASSWORD" ]] && PASSWORD="$SERVICE_PASSWORD" + if [[ -n "$SERVICE_PASSWORD" ]]; then + PASSWORD="$SERVICE_PASSWORD" + dokku_log_warn "Specified password may not be as secure as the auto-generated password" + fi echo "$PASSWORD" > "$SERVICE_ROOT/PASSWORD" chmod 640 "$SERVICE_ROOT/PASSWORD" sed -i.bak "s/# requirepass.*/requirepass ${PASSWORD}/" "$SERVICE_ROOT/config/redis.conf" && rm "$SERVICE_ROOT/config/redis.conf.bak"